Updates to double-sided materials for 1.39 #1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasharrysson
commented
Jun 4, 2024
| @@ -221,6 +221,7 @@ | |||
| <input name="bsdf" type="BSDF" value="" doc="Distribution function for surface scattering." /> | |||
| <input name="edf" type="EDF" value="" doc="Distribution function for surface emission." /> | |||
| <input name="opacity" type="float" value="1.0" doc="Surface cutout opacity" /> | |||
| <input name="thin_walled" type="boolean" value="false" uniform="true" doc="Option to make the surface thin-walled." /> | |||
| <output name="out" type="surfaceshader" /> | |||
| </nodedef> | |||
|
|
|||
There was a problem hiding this comment.
Note that the old deprecated node thin_surface still remains below, and we can remove this in another PR.
I'm not sure if we need to add code for upgrading from thin_surface to surface with thin_walled enabled? The thin_surface node was never implemented in any backends, except maybe MDL, so I'm not sure if this was ever used by anyone.
There was a problem hiding this comment.
That's a good question, and my own sense is that the deprecated thin_surface node has not yet been used in real-world assets, because it's only been supported on a single target. So I'd say that it's likely safe to remove this node without an upgrade path in a future change.
jstone-lucasfilm
approved these changes
Jun 5, 2024
44bf535
into
AcademySoftwareFoundation:main
34 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change list updates the library files so they match the definitions for
surfacematerialandsurfacenodes in v1.39.