anisotropic_vdf closure should not set IOR #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s take priority Signed-off-by: Chris Kulla <ckulla@gmail.com>
lgritz
approved these changes
Sep 23, 2024
00473ce
into
AcademySoftwareFoundation:main
20 of 22 checks passed
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Sep 24, 2024
…ation#1870) The MaterialX team noticed this issue here: AcademySoftwareFoundation/MaterialX#2016 Basically, if you add a medium through the anisotropic_vdf closure, it should not force the ior back to 1.0 as this IOR might have been changed by one of the microfacet closures. The IOR already defaults to 1.0 so cases that do not involve a microfacet closure are not affected. Signed-off-by: Chris Kulla <ckulla@gmail.com>
lgritz
pushed a commit
to lgritz/OpenShadingLanguage
that referenced
this pull request
Sep 24, 2024
…ation#1870) The MaterialX team noticed this issue here: AcademySoftwareFoundation/MaterialX#2016 Basically, if you add a medium through the anisotropic_vdf closure, it should not force the ior back to 1.0 as this IOR might have been changed by one of the microfacet closures. The IOR already defaults to 1.0 so cases that do not involve a microfacet closure are not affected. Signed-off-by: Chris Kulla <ckulla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MaterialX team noticed this issue here: AcademySoftwareFoundation/MaterialX#2016
Basically, if you add a medium through the
anisotropic_vdfclosure, it should not force the ior back to 1.0 as this IOR might have been changed by one of the microfacet closures. The IOR already defaults to 1.0 so cases that do not involve a microfacet closure are not affected.Checklist:
already run clang-format v17 before submitting, I definitely will look at
the CI test that runs clang-format and fix anything that it highlights as
being nonconforming.