Add partial like in item with variants #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
renaudjenny
commented
Dec 28, 2020
- Add an half star to show that the item has been partially completed, meaning at least one of its variants is liked, but not all of them.
- Display bottom sheet variations if the item has variants instead of adding it to the collection without their variants.
- Fix Urgently need fix #230
* Add an half star to show that the item has been partially completed, meaning at least one of its variants is liked, but not all of them.
* Display bottom sheet variations if the item has variants instead of adding it to the collection without their variants.
* Previously the item wasn't marked as liked if one of its variant is liked
|
LOL I wanted to show a video recording of the result, but it's now impossible to upload video on GitHub :( |
|
|
Closed
Dimillian
reviewed
Jan 2, 2021
|
|
||
| if !items.contains(item) && variants.completionStatus(for: item) != .unstarted { | ||
| // We add the item to the liked items if at least one of its variant is added | ||
| toggleItem(item: item) |
There was a problem hiding this comment.
You should _ = to silence the warning.
Dimillian
reviewed
Jan 2, 2021
| toggleItem(item: item) | ||
| } else if items.contains(item) && variants.completionStatus(for: item) == .unstarted { | ||
| // We remove the item from the liked items if there is none of its variants liked | ||
| toggleItem(item: item) |
There was a problem hiding this comment.
Done, I'm also wondering if at the end of the day @discardableResult could come handy for the function. As it's not used in a lot of places, I think that's fine for now.
|
I love the functionality and it works very good from the list, but it missing two things.
Appart from that, awesome! |
|
Hi @Dimillian, yes good idea, I will work on that today 🙂 |
…at-add-partial-like-in-item-with-variants
* Also refactor the Bottom sheet view to let it be in its own View * Add the behaviour inside the ItemDetailView for the main Like button, so it fixes the "doing nothing" behaviour
|
@Dimillian, animation is done, I really like it! Let me know if you do too � |
|
Love it! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.