Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update harden-update-ad-fs-pingfederate.md #1227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iam-ray
Copy link

@iam-ray iam-ray commented Nov 5, 2024

The 2.4.x.0 versions have been released for download, and not autoupgrade.

The 2.4.x.0 versions have been released for download, and not autoupgrade.
Copy link
Contributor

@iam-ray : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit b817a80:

⚠️ Validation status: warnings

File Status Preview URL Details
docs/identity/hybrid/connect/harden-update-ad-fs-pingfederate.md ⚠️Warning Details

docs/identity/hybrid/connect/harden-update-ad-fs-pingfederate.md

  • Line 46, Column 159: [Warning: hard-coded-locale - See documentation] Link 'https://learn.microsoft.com/en-us/entra/identity/hybrid/connect/reference-connect-version-history' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
  • Line 46, Column 159: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/en-us/entra/identity/hybrid/connect/reference-connect-version-history' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@Jak-MS
Copy link
Contributor

Jak-MS commented Nov 5, 2024

@billmath
Can you review the proposed changes?

Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link

github-actions bot commented Feb 3, 2025

This pull request has been inactive for 90 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions.

If this PR is inactive for 1 more day, it will be closed automatically. Thank you!

Microsoft Entra Content Team Contact Us

@v-dirichards
Copy link
Contributor

@billmath Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants