-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONCEPT_ID (to NULL or not to NULL) #11
Comments
Hi @ericaVoss , @clairblacketer , @MelaniePhilofsky - what do you think about expanding the list of fields which can be left NULL if no source value is available? There are other non-required concept ID fields to which I think this convention should also apply (e.g. ADMITTED_FROM_CONCEPT_ID, DISCHARGED_TO_CONCEPT_ID, CONDITION_STATUS_CONCEPT_ID). If you agree, I'm happy to submit a PR to CDM docs :) thanks! |
Hi @katy-sadowski I agree these are good contenders :) This would constitute a change to the model, not just the documentation so we can put it in as a proposal for v5.5 |
Per the CDM v5.4 documentation, the fields @katy-sadowski identified above are not required. So, a change to the model isn't necessary. They are already nullable. Katy - Which documents need to be changed? |
@MelaniePhilofsky that makes sense. In the documentation it does not state that the fields can be null while in other fields it does, like unit_concept_id. |
The docs that need updating are:
I think this can go in 5.4 since it's more of a clarification than change to convention? |
Yes, I agree this is a clarification and not a change. And if it is ambiguous, then let's fix it. Should we create one general statement, "If a field is not required, then leave NULL if you do not have source data for the field"? Or should we add a sentence to every nullable field? I prefer concise documentation, we already have pages and pages of CDM documentation. |
2) Update language in the WIKI under CONCEPT_ID
https://github.com/OHDSI/CommonDataModel/wiki/Data-Model-Conventions
The text was updated successfully, but these errors were encountered: