Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle room deletions correctly #7

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Handle room deletions correctly #7

merged 1 commit into from
Mar 11, 2020

Conversation

abbodh
Copy link
Contributor

@abbodh abbodh commented Mar 11, 2020

  • [Issue] sync service deletes all favorite rooms when room from exchange got removed.
  • [Fix]
    • Updated sync service to get rooms which are not found in new run and mark for deletion
    • modified RoomCollection table to use IsDeleted flag instead of deleting the rooms
    • added a cache layer to reduce trip to table storage for all rooms

bug fix for handling room deletion
124a95c 
- [Issue] - sync service deletes all favorite rooms when room from exchange got removed.
- [Fix]
  * Updated sync service to get rooms which are not found in new run and mark for deletion
  * modified RoomCollection table to use IsDeleted flag instead of deleting the rooms
  * added a cache layer to reduce trip to table storage for all rooms
@abbodh abbodh requested a review from aosolis March 11, 2020 03:54
@aosolis aosolis changed the title bug fix for handling room deletion Handle room deletions correctly Mar 11, 2020
aosolis
aosolis approved these changes Mar 11, 2020
View reviewed changes
Copy link

@aosolis aosolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on earlier internal review

@abbodh abbodh merged commit 8648088 into master Mar 11, 2020
@abbodh abbodh deleted the abbodh/syncservice-bugfix branch March 11, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aosolis aosolis aosolis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abbodh @aosolis