Clean up tests #58
Merged
Clean up tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagheyman
suggested changes
Feb 16, 2018
ykman/device.py
Outdated
| @@ -180,6 +184,10 @@ def use_transport(self, transport): | |||
| assert dev.mode == my_mode | |||
| return dev | |||
|
|
|||
| def close(self): | |||
| logger.debug('close') | |||
There was a problem hiding this comment.
Remove this log message or improve it a bit.
ykman/driver.py
Outdated
| @@ -64,3 +68,6 @@ def read_capabilities(self): | |||
| def guess_version(self): | |||
| # Second arg is True if the version is certain, False if not. | |||
| return (0, 0, 0), False | |||
|
|
|||
| def close(self): | |||
| logger.debug('close') | |||
There was a problem hiding this comment.
See above (about log msg)
test/test_external_libs.py
Outdated
| from test.util import ykman_cli | ||
|
|
||
|
|
||
| @unittest.skipIf( | ||
| os.environ.get('INTEGRATION_TESTS') != 'TRUE', 'INTEGRATION_TESTS != TRUE') |
There was a problem hiding this comment.
Are you sure about this? Shouldn't the python only unittests be able to run without the libraries in place?
There was a problem hiding this comment.
Oooh, now I see why this was there. Good catch, thanks! This should just be updated to use the new environment variable, then.
There was a problem hiding this comment.
Case in point: all CI builds failed... �
|
Very nice, I look forward to approving :) |
dainnilsson
approved these changes
Feb 16, 2018
dagheyman
approved these changes
Feb 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests now reliably pass in both Linux and Mac!