-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(electron): add support #135
Conversation
#102 is only based off the user agent string which can change at anytime and also users can change it on their own. Also this uses browser platform code. Browser platform code lacks ability to grab UUID and other things so its not really a good solution for electron support In short it will close both. |
8b405c0
to
4a75ca3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm -- but travis tests are reporting eslint errors that should be resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3f06fbe
to
71dd844
Compare
71dd844
to
c79aa8e
Compare
c79aa8e
to
3ddcb21
Compare
Platforms affected
electron
Motivation and Context
Add Electron Support
closes: #102
closes: #99
Description
Added sub-npm-package for Cordova-Electron
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)