Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): getInfo response to include sdkVersion #157

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 1, 2022

Platforms affected

Android

Motivation and Context

Resolves #142

Description

Refactored and re-added the getSDKVersion method.

getInfo response to contain sdkVersion property and added to the window.device object.

Device Object

Testing

  • Build App
  • Confirmed window.device object
  • Called getInfo
device.getInfo(
    result => {
        console.log("Success Result", result);
    },
    error => {
        console.log("Error", error);
    }
)

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from breautek April 1, 2022 12:29
README.md Outdated Show resolved Hide resolved
Co-authored-by: Norman Breau <norman@nbsolutions.ca>
@erisu erisu merged commit d217d6a into apache:master Apr 1, 2022
@erisu erisu deleted the feat/add-sdkversion branch April 1, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why isn't the getSDKVersion() function being used?
2 participants