Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15045: (KIP-924 pt. 3) Implement KafkaStreamsAssignment #15944

Merged
merged 4 commits into from
May 15, 2024

Conversation

apourchet
Copy link
Contributor

@apourchet apourchet commented May 13, 2024

This PR changes KafkaStreamsAssignment from an interface to a container class, and implements said class.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

apourchet added 2 commits May 13, 2024 14:48
This change implements the KafkaStreamsAssignment interface via the
KafkaStreamsAssignmentImpl internal read-only container class.
Copy link
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ableegoldman
Copy link
Member

The test env seems pretty unstable right now but we have at least one clean build for each java version if you look at the two latest runs. All test failures are unrelated as well. Seems safe to merge

@ableegoldman ableegoldman merged commit cb96884 into apache:trunk May 15, 2024
1 check failed
@ableegoldman
Copy link
Member

Merged to trunk. I'll update the KIP and send out a notice about the change from interface to class and the new APIs

TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
…#15944)

This PR changes KafkaStreamsAssignment from an interface to a container class, and implements said class.

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
…#15944)

This PR changes KafkaStreamsAssignment from an interface to a container class, and implements said class.

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants