Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-15045: (KIP-924 pt. 6) Post process new assignment structure #16002

Merged
merged 1 commit into from
May 21, 2024

Conversation

apourchet
Copy link
Contributor

@apourchet apourchet commented May 20, 2024

This PR creates the required methods to post-process the result of TaskAssignor.assign into the required ClientMetadata map. This allows most of the internal logic to remain intact after the user's assignment code runs.

This PR creates the required methods to post-process the result of
TaskAssignor.assign into the required ClientMetadata map. This allows
most of the internal logic to remain intact after the user's assignment
code runs.
Copy link
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ableegoldman
Copy link
Member

Test failures are unrelated, merging to trunk

Worth noting that the org.apache.kafka.streams.processor.internals.assignment.TaskAssignorConvergenceTest did fail, which may seem related, but cannot be since this PR only adds new methods. Furthermore, I have seen this test fail occasionally in recent weeks, and while this is probably a real bug/failure (see comment), it seems to have been flaky since before we started work on KIP-924 so it must be unrelated. Just mentioning this in case we see this fail on future KIP-924 PRs that do more than just add new methods

@ableegoldman ableegoldman merged commit 6339e3a into apache:trunk May 21, 2024
1 check failed
rreddy-22 pushed a commit to rreddy-22/kafka-rreddy that referenced this pull request May 24, 2024
…pache#16002)

This PR creates the required methods to post-process the result of TaskAssignor.assign into the required ClientMetadata map. This allows most of the internal logic to remain intact after the user's assignment code runs.

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Jun 1, 2024
…pache#16002)

This PR creates the required methods to post-process the result of TaskAssignor.assign into the required ClientMetadata map. This allows most of the internal logic to remain intact after the user's assignment code runs.

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
…pache#16002)

This PR creates the required methods to post-process the result of TaskAssignor.assign into the required ClientMetadata map. This allows most of the internal logic to remain intact after the user's assignment code runs.

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
…pache#16002)

This PR creates the required methods to post-process the result of TaskAssignor.assign into the required ClientMetadata map. This allows most of the internal logic to remain intact after the user's assignment code runs.

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants