-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KAFKA-17192 Fix MirrorMaker2 worker config does not pass config.provi… #16678
Conversation
…ders value to connectors Change-Id: I38185158116a43899497f66c1fb643677491b6eb
ca7ce6a
to
034288f
Compare
Usually the PR get merged to trunk first then cherry-pick the pr commit from trunk into the release branch |
return entriesWithPrefix(map, prefix, strip, false); | ||
} | ||
|
||
public static <V> Map<String, V> entriesWithPrefix(Map<String, V> map, String prefix, boolean strip, boolean allowMatchingLength) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a Javadoc for this? It can be largely identical to the one above, just needs to include an additional description for the allowMatchingLength
parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, I have added it
Thanks @k0b3rIT! Looks good for the most part, just one small comment request. Can you also add a description for the changes to your PR (where the "More detailed description of your change" template currently is)? |
Change-Id: If65e2c57039ae3eca163cbd183c03ab4aa384ecc
All done, Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@cmccabe I'd like to backport this low-risk change to 3.9. Is that alright with you? |
@k0b3rIT I can backport this to 3.7 and 3.8 once it's also backported to 3.9. We've just cut a new branch for the upcoming 3.9.0 release so I've asked the release manager if it's okay to backport this to 3.9 right now. If we can't backport to 3.9 right now, I'll be sure to backport it to 3.9, 3.8, and 3.7 once 3.9.0 is released. |
I don't see why we can't backport to 3.9 |
#16678) Reviewers: Chris Egerton <chrise@aiven.io>
Thanks Colin! Backported to 3.9. |
#16678) Reviewers: Chris Egerton <chrise@aiven.io>
And 3.8. |
#16678) Reviewers: Chris Egerton <chrise@aiven.io>
Aaaaaand 3.7. |
…ders value to connectors
A new method got introduced beside the existing
entriesWithPrefix
with an extended parameter list (allowMatchingLength
) that allows the user to configure its behavior when the property key is exactly the same as the prefix.Testing:
Worker config test got extended to assert on a property (config.providers) that matches with the prefix
Committer Checklist (excluded from commit message)