Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-17192 Fix MirrorMaker2 worker config does not pass config.provi… #16678

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

k0b3rIT
Copy link
Contributor

@k0b3rIT k0b3rIT commented Jul 24, 2024

…ders value to connectors

A new method got introduced beside the existingentriesWithPrefix with an extended parameter list (allowMatchingLength) that allows the user to configure its behavior when the property key is exactly the same as the prefix.

Testing:
Worker config test got extended to assert on a property (config.providers) that matches with the prefix

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…ders value to connectors

Change-Id: I38185158116a43899497f66c1fb643677491b6eb
@OmniaGM
Copy link
Collaborator

OmniaGM commented Jul 24, 2024

@k0b3rIT duplicate PR with #16677

@k0b3rIT
Copy link
Contributor Author

k0b3rIT commented Jul 24, 2024

@k0b3rIT duplicate PR with #16677

Actually this is for the trunk, and the other one is for the 3.7.
I am not sure how the backporting process works. I ran into this on 3.7, but noticed that its present on the trunk too. Thats why I opened PR for both

Change-Id: Icbf3f25d9e25c26e8992e656cdb9bb8bddb55925
@k0b3rIT k0b3rIT force-pushed the KAFKA-17192_trunk branch from ca7ce6a to 034288f Compare July 24, 2024 11:34
@OmniaGM
Copy link
Collaborator

OmniaGM commented Jul 24, 2024

Usually the PR get merged to trunk first then cherry-pick the pr commit from trunk into the release branch

@C0urante C0urante added mirror-maker-2 backport-candidate This pull request is a candidate to be backported to previous versions labels Jul 24, 2024
return entriesWithPrefix(map, prefix, strip, false);
}

public static <V> Map<String, V> entriesWithPrefix(Map<String, V> map, String prefix, boolean strip, boolean allowMatchingLength) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a Javadoc for this? It can be largely identical to the one above, just needs to include an additional description for the allowMatchingLength parameter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I have added it

@C0urante
Copy link
Contributor

Thanks @k0b3rIT! Looks good for the most part, just one small comment request. Can you also add a description for the changes to your PR (where the "More detailed description of your change" template currently is)?

Change-Id: If65e2c57039ae3eca163cbd183c03ab4aa384ecc
@k0b3rIT
Copy link
Contributor Author

k0b3rIT commented Jul 29, 2024

Thanks @k0b3rIT! Looks good for the most part, just one small comment request. Can you also add a description for the changes to your PR (where the "More detailed description of your change" template currently is)?

All done, Thanks a lot!

Copy link
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@C0urante C0urante merged commit 8d8c367 into apache:trunk Jul 31, 2024
1 check failed
@C0urante
Copy link
Contributor

@cmccabe I'd like to backport this low-risk change to 3.9. Is that alright with you?

@C0urante
Copy link
Contributor

@k0b3rIT I can backport this to 3.7 and 3.8 once it's also backported to 3.9. We've just cut a new branch for the upcoming 3.9.0 release so I've asked the release manager if it's okay to backport this to 3.9 right now. If we can't backport to 3.9 right now, I'll be sure to backport it to 3.9, 3.8, and 3.7 once 3.9.0 is released.

@cmccabe
Copy link
Contributor

cmccabe commented Aug 1, 2024

I don't see why we can't backport to 3.9

C0urante pushed a commit that referenced this pull request Aug 1, 2024
@C0urante
Copy link
Contributor

C0urante commented Aug 1, 2024

Thanks Colin! Backported to 3.9.

C0urante pushed a commit that referenced this pull request Aug 1, 2024
@C0urante
Copy link
Contributor

C0urante commented Aug 1, 2024

And 3.8.

C0urante pushed a commit that referenced this pull request Aug 1, 2024
@C0urante
Copy link
Contributor

C0urante commented Aug 1, 2024

Aaaaaand 3.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate This pull request is a candidate to be backported to previous versions mirror-maker-2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants