KAFKA-18341: Remove KafkaConfig GroupType config check and warn log #18320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A label of 'needs-attention' was automatically added to this PR in order to raise the |
dajac
reviewed
Jan 9, 2025
| @@ -542,15 +542,7 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) | |||
| if (!protocols.contains(GroupType.CLASSIC)) { | |||
| throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}' protocol is not supported.") | |||
| } | |||
| if (protocols.contains(GroupType.CONSUMER)) { | |||
| if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) { | |||
There was a problem hiding this comment.
I think that we need to keep the second part of the condition.
| @@ -542,15 +542,7 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) | |||
| if (!protocols.contains(GroupType.CLASSIC)) { | |||
| throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}' protocol is not supported.") | |||
| } | |||
| if (protocols.contains(GroupType.CONSUMER)) { | |||
| if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) { | |||
| warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is only supported in KRaft cluster with the new group coordinator.") | |||
| if (protocols.contains(GroupType.SHARE)) { | ||
| if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) { |
dajac
pushed a commit
that referenced
this pull request
Jan 13, 2025
…18320) As ZK mode is being removed for 4.0, we don't need this check anymore. Reviewers: David Jacot <djacot@confluent.io>
|
Merged to trunk and 4.0. |
tedyyan
pushed a commit
to tedyyan/kafka
that referenced
this pull request
Jan 13, 2025
…pache#18320) As ZK mode is being removed for 4.0, we don't need this check anymore. Reviewers: David Jacot <djacot@confluent.io>
askew
pushed a commit
to askew/kafka
that referenced
this pull request
Jan 23, 2025
…pache#18320) As ZK mode is being removed for 4.0, we don't need this check anymore. Reviewers: David Jacot <djacot@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.apache.org/jira/browse/KAFKA-18341
As we will remove zookeeper, we don't need this warn log when we start server
Committer Checklist (excluded from commit message)