KAFKA-18399 Remove ZooKeeper from KafkaApis (2/N): CONTROLLED_SHUTDOWN , ENVELOPE #18422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
chia7712
reviewed
Jan 8, 2025
| @@ -249,7 +239,6 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| case ApiKeys.ALTER_USER_SCRAM_CREDENTIALS => maybeForwardToController(request, handleAlterUserScramCredentialsRequest) | |||
| case ApiKeys.ALTER_PARTITION => handleAlterPartitionRequest(request) | |||
| case ApiKeys.UPDATE_FEATURES => maybeForwardToController(request, handleUpdateFeatures) | |||
| case ApiKeys.ENVELOPE => handleEnvelope(request, requestLocal) | |||
There was a problem hiding this comment.
It seems to me using KafkaApis.shouldNeverReceive(request) is more readable.
There was a problem hiding this comment.
Done. Thanks for review.
|
@TaiJuWu please fix conflicts |
Done. PTAL. |
|
failed test is traced by https://issues.apache.org/jira/browse/KAFKA-15474 |
chia7712
pushed a commit
that referenced
this pull request
Jan 9, 2025
…N and ENVELOPE (#18422) Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
m1a2st
pushed a commit
to m1a2st/kafka
that referenced
this pull request
Jan 10, 2025
…N and ENVELOPE (apache#18422) Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
Jan 10, 2025
…emove-metadata-version-methods-for-versions-older-than-3.0 * apache-github/trunk: KAFKA-18340: Change Dockerfile to use log4j2 yaml instead log4j properties (apache#18378) MINOR: fix flaky RemoteLogManagerTest#testStopPartitionsWithDeletion (apache#18474) KAFKA-18311: Enforcing copartitioned topics (4/N) (apache#18397) KAFKA-18308; Update CoordinatorSerde (apache#18455) KAFKA-18440: Convert AuthorizationException to fatal error in AdminClient (apache#18435) KAFKA-17671: Create better documentation for transactions (apache#17454) KAFKA-18304; Introduce json converter generator (apache#18458) MINOR: Clean up classic group tests (apache#18473) KAFKA-18399 Remove ZooKeeper from KafkaApis (2/N): CONTROLLED_SHUTDOWN and ENVELOPE (apache#18422) MINOR: improve StreamThread periodic processing log (apache#18430)
askew
pushed a commit
to askew/kafka
that referenced
this pull request
Jan 23, 2025
…N and ENVELOPE (apache#18422) Reviewers: Ken Huang <s7133700@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KRaft mode does not support follow RPC and this PR would remove them.
Committer Checklist (excluded from commit message)