KAFKA-18399 Remove ZooKeeper from KafkaApis (4/N): CREATE_TOPICS, DELETE_TOPICS, CREATE_PARTITIONS #18433
+4
−559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Jan 8, 2025
| @@ -212,8 +208,8 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| case ApiKeys.LIST_GROUPS => handleListGroupsRequest(request).exceptionally(handleError) | |||
| case ApiKeys.SASL_HANDSHAKE => handleSaslHandshakeRequest(request) | |||
| case ApiKeys.API_VERSIONS => handleApiVersionsRequest(request) | |||
| case ApiKeys.CREATE_TOPICS => maybeForwardToController(request, handleCreateTopicsRequest) | |||
| case ApiKeys.DELETE_TOPICS => maybeForwardToController(request, handleDeleteTopicsRequest) | |||
| case ApiKeys.CREATE_TOPICS => maybeForwardToController(request, null) | |||
There was a problem hiding this comment.
we should use KafkaApis.shouldAlwaysForward to replace null
| case ApiKeys.CREATE_TOPICS => maybeForwardToController(request, handleCreateTopicsRequest) | ||
| case ApiKeys.DELETE_TOPICS => maybeForwardToController(request, handleDeleteTopicsRequest) | ||
| case ApiKeys.CREATE_TOPICS => maybeForwardToController(request, null) | ||
| case ApiKeys.DELETE_TOPICS => maybeForwardToController(request, null) |
| @@ -230,7 +226,7 @@ class KafkaApis(val requestChannel: RequestChannel, | |||
| case ApiKeys.ALTER_REPLICA_LOG_DIRS => handleAlterReplicaLogDirsRequest(request) | |||
| case ApiKeys.DESCRIBE_LOG_DIRS => handleDescribeLogDirsRequest(request) | |||
| case ApiKeys.SASL_AUTHENTICATE => handleSaslAuthenticateRequest(request) | |||
| case ApiKeys.CREATE_PARTITIONS => maybeForwardToController(request, handleCreatePartitionsRequest) | |||
| case ApiKeys.CREATE_PARTITIONS => maybeForwardToController(request, null) | |||
There was a problem hiding this comment.
All comments are address, thanks!
This reverts commit 6db17a2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*More detailed description of your change
Delete follow KafkaApi handler
In Kraft mode, all requests are forwarded to controller and all authorization is not work so I delete some tests.
Forwarding test already cover by
Committer Checklist (excluded from commit message)