KAFKA-18446:Remove MetadataCacheControllerNodeProvider #18437
+20
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gongxuanzhang please fix the conflicts |
b46989c to
d1b1d9d
Compare
…etadata # Conflicts: # core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala
|
@chia7712 PTAL |
chia7712
reviewed
Jan 9, 2025
| zkControllerListenerName, | ||
| zkControllerSecurityProtocol, | ||
| zkControllerSaslMechanism, | ||
| isZkController = true) |
There was a problem hiding this comment.
Could you please remove isZkController and isNetworkClientForZkController from this class file?
|
@chia7712 PTAL |
chia7712
reviewed
Jan 9, 2025
There was a problem hiding this comment.
@gongxuanzhang thanks for this patch. two minor comments are left
| @@ -244,7 +210,6 @@ case class NodeToControllerQueueItem( | |||
|
|
|||
| class NodeToControllerRequestThread( | |||
| initialNetworkClient: KafkaClient, | |||
| var isNetworkClientForZkController: Boolean, | |||
| networkClientFactory: ControllerInformation => KafkaClient, | |||
There was a problem hiding this comment.
networkClientFactory can be removed now
| isNetworkClientForZkController = controllerInformation.isZkController | ||
| updateControllerAddress(controllerInformation.node.orNull) | ||
| controllerInformation.node.foreach(n => metadataUpdater.setNodes(Seq(n).asJava)) | ||
| networkClient = networkClientFactory(controllerInformation) |
There was a problem hiding this comment.
we don't change networkClient anymore, so networkClient can be declared as final variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue
format import by spotless