KAFKA-18445: Remove LazyDownConversionRecords and LazyDownConversionRecordsSend #18445
+0
−611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chia7712
reviewed
Jan 9, 2025
| @@ -203,8 +203,7 @@ public static FetchResponseData.PartitionData partitionResponse(int partition, E | |||
| * Returns `partition.records` as `Records` (instead of `BaseRecords`). If `records` is `null`, returns `MemoryRecords.EMPTY`. | |||
| * | |||
| * If this response was deserialized after a fetch, this method should never fail. An example where this would | |||
| * fail is a down-converted response (e.g. LazyDownConversionRecords) on the broker (before it's serialized and | |||
| * sent on the wire). | |||
| * fail is a down-converted response on the broker (before it's serialized and sent on the wire). | |||
There was a problem hiding this comment.
the message conversion has been removed by #18218, so this comment is stale. could you please remove it?
| @@ -124,8 +124,7 @@ public static ShareFetchResponse parse(ByteBuffer buffer, short version) { | |||
| * Returns `partition.records` as `Records` (instead of `BaseRecords`). If `records` is `null`, returns `MemoryRecords.EMPTY`. | |||
| * | |||
| * <p>If this response was deserialized after a share fetch, this method should never fail. An example where this would | |||
| * fail is a down-converted response (e.g. LazyDownConversionRecords) on the broker (before it's serialized and | |||
| * sent on the wire). | |||
| * fail is a down-converted response on the broker (before it's serialized and sent on the wire). | |||
docs/upgrade.html
Outdated
| @@ -75,6 +75,8 @@ <h5><a id="upgrade_400_notable" href="#upgrade_400_notable">Notable changes in 4 | |||
| </li> | |||
| <li>The function <code>onNewBatch</code> in <code>org.apache.kafka.clients.producer.Partitioner</code> class was removed. | |||
| </li> | |||
| <li>The <code>org.apache.kafka.common.record.LazyDownConversionRecords</code> class and <code>org.apache.kafka.common.record.LazyDownConversionRecordsSend</code> class were removed. | |||
There was a problem hiding this comment.
they are not public APIs so we don't need to add them into upgrade.html
| // of temporary memory used for down-conversion, etc. Pull out any such statistics from the underlying send | ||
| // and fold it up appropriately. | ||
| if (completedSend instanceof LazyDownConversionRecordsSend) { | ||
| if (recordConversionStats == null) |
There was a problem hiding this comment.
we can remove recordConversionStats and recordConversionStats(), right?
chia7712
approved these changes
Jan 9, 2025
chia7712
pushed a commit
that referenced
this pull request
Jan 9, 2025
…cordsSend (#18445) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Committer Checklist (excluded from commit message)