KAFKA-18308; Update CoordinatorSerde #18455
Open
+83
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewJSchofield
requested changes
Jan 9, 2025
| record.key().message() | ||
| ); | ||
| } | ||
|
|
||
| @Override | ||
| protected ApiMessage apiMessageKeyFor(short recordVersion) { |
There was a problem hiding this comment.
Personally, I would take this opportunity to stop using "recordVersion" as the variable name here. Really, it has become record type, which happened to be implemented as a version number.
| @@ -43,7 +43,7 @@ public abstract class CoordinatorRecordSerde implements Serializer<CoordinatorRe | |||
| @Override | |||
| public byte[] serializeKey(CoordinatorRecord record) { | |||
| // Record does not accept a null key. | |||
| return MessageUtil.toVersionPrefixedBytes( | |||
| return MessageUtil.toCoordinatorTypePrefixedBytes( | |||
There was a problem hiding this comment.
So, it seems to me that toCoordinatorTypePrefixedBytes fixes the version of the key schema as 0, but using toVersionPrefixedBytes permits other versions of the record schemas. However, if I understand correctly, we do not want to use record schemas above 0 and prefer tagged fields for new fields added to records. What is the correct way to version records in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the GroupCoordinatorSerde and the ShareGroupCoordinatorSerde to leverage the CoordinatorRecordType to deserialize records. With this, newly added record are automatically picked up. In other words, the serdes work with all defined records without doing anything.
Committer Checklist (excluded from commit message)