Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Use Java 8 lambdas in KStreamImplTest #6430

Merged
merged 2 commits into from
Mar 12, 2019
Merged

MINOR: Use Java 8 lambdas in KStreamImplTest #6430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2addd76
MINOR: Use Java 8 lambdas in KStreamImplTest
bbejeck Mar 11, 2019
cc387bc
MINOR: Updates per comments
bbejeck Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/kafka/tools/StreamsResetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ private void parseArguments(final String[] args) throws IOException {
CommandLineUtils.printUsageAndDie(optionParser, "Only one of --dry-run and --execute can be specified");
}

final scala.collection.immutable.HashSet<OptionSpec<?>> allScenarioOptions = new scala.collection.immutable.HashSet<OptionSpec<?>>();
final scala.collection.immutable.HashSet<OptionSpec<?>> allScenarioOptions = new scala.collection.immutable.HashSet<>();
allScenarioOptions.$plus(toOffsetOption);
allScenarioOptions.$plus(toDatetimeOption);
allScenarioOptions.$plus(byDurationOption);
Expand Down
73 changes: 13 additions & 60 deletions streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,78 +104,31 @@ public void testNumProcesses() {

final KStream<String, String> source2 = builder.stream(Arrays.asList("topic-3", "topic-4"), stringConsumed);

final KStream<String, String> stream1 =
source1.filter(new Predicate<String, String>() {
@Override
public boolean test(final String key, final String value) {
return true;
}
}).filterNot(new Predicate<String, String>() {
@Override
public boolean test(final String key, final String value) {
return false;
}
});
final KStream<String, String> stream1 = source1.filter((key, value) -> true)
.filterNot((key, value) -> false);

final KStream<String, Integer> stream2 = stream1.mapValues(new ValueMapper<String, Integer>() {
@Override
public Integer apply(final String value) {
return new Integer(value);
}
});
final KStream<String, Integer> stream2 = stream1.mapValues(Integer::new);

final KStream<String, Integer> stream3 = source2.flatMapValues(new ValueMapper<String, Iterable<Integer>>() {
@Override
public Iterable<Integer> apply(final String value) {
return Collections.singletonList(new Integer(value));
}
});
final KStream<String, Integer> stream3 = source2.flatMapValues((ValueMapper<String, Iterable<Integer>>)
value -> Collections.singletonList(new Integer(value)));

final KStream<String, Integer>[] streams2 = stream2.branch(
new Predicate<String, Integer>() {
@Override
public boolean test(final String key, final Integer value) {
return (value % 2) == 0;
}
},
new Predicate<String, Integer>() {
@Override
public boolean test(final String key, final Integer value) {
return true;
}
}
(key, value) -> (value % 2) == 0,
(key, value) -> true
);

final KStream<String, Integer>[] streams3 = stream3.branch(
new Predicate<String, Integer>() {
@Override
public boolean test(final String key, final Integer value) {
return (value % 2) == 0;
}
},
new Predicate<String, Integer>() {
@Override
public boolean test(final String key, final Integer value) {
return true;
}
}
(key, value) -> (value % 2) == 0,
(key, value) -> true
);

final int anyWindowSize = 1;
final Joined<String, Integer, Integer> joined = Joined.with(Serdes.String(), Serdes.Integer(), Serdes.Integer());
final KStream<String, Integer> stream4 = streams2[0].join(streams3[0], new ValueJoiner<Integer, Integer, Integer>() {
@Override
public Integer apply(final Integer value1, final Integer value2) {
return value1 + value2;
}
}, JoinWindows.of(ofMillis(anyWindowSize)), joined);
final KStream<String, Integer> stream4 = streams2[0].join(streams3[0],
(value1, value2) -> value1 + value2, JoinWindows.of(ofMillis(anyWindowSize)), joined);

streams2[1].join(streams3[1], new ValueJoiner<Integer, Integer, Integer>() {
@Override
public Integer apply(final Integer value1, final Integer value2) {
return value1 + value2;
}
}, JoinWindows.of(ofMillis(anyWindowSize)), joined);
streams2[1].join(streams3[1], (value1, value2) -> value1 + value2,
JoinWindows.of(ofMillis(anyWindowSize)), joined);

stream4.to("topic-5");

Expand Down