KAFKA-1595; Remove deprecated and slower scala JSON parser #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple test that shows existing behaviour.
….consumer.TopicCount A thin wrapper over Jackson's Tree Model API is used as the replacement. This wrapper increases safety while providing a simple, but powerful API through the usage of the `DecodeJson` type class. Even though this has a maintenance cost, it makes the API much more convenient from Scala. A number of tests were added to verify the behaviour of this wrapper. The Scala module for Jackson doesn't provide any help for our current usage, so we don't depend on it. An attempt has been made to maintain the existing behaviour regarding when exceptions are thrown. There are a number of cases where `JsonMappingException` will be thrown instead of `ClassCastException`, however. It is expected that users would not try to catch `ClassCastException`.
resetius
added a commit
to resetius/kafka
that referenced
this pull request
Dec 5, 2016
…2-no-flush-on-shutdown [LOGBROKER-2032] Add unclean.shutdown.enable config option which disables log flush on shutdown (off by default)
rustd
pushed a commit
to rustd/pranavfinaldemokafka
that referenced
this pull request
Feb 9, 2024
…pache#74) In two situations, the current code could transition the ChangelogReader to UpdateStandby when already in that state, causing an IllegalStateException. Namely these two cases are: 1. When only standby tasks are restoring and one of them crashes. 2. When only standby tasks are restoring and one of them is paused. This change fixes both issues by only transitioning if the paused or failed task is an active task. Reviewer: Bruno Cadonna <cadonna@apache.org> Co-authored-by: Lucas Brutschy <lucasbru@users.noreply.github.com>
3 tasks
patrik-marton
pushed a commit
to patrik-marton/kafka
that referenced
this pull request
Mar 11, 2025
CSMDS-564: Fix GHA runner label for unit tests (apache#74) CSMDS-885: Jenkins unit tester action - patching api4jenkins with MavenModuleSetBuild (apache#129) CSMDS-882: Updating workflow runner to redhat8-builds (apache#128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thin wrapper over Jackson's Tree Model API is used as the replacement. This wrapper
increases safety while providing a simple, but powerful API through the usage of the
DecodeJsontype class. Even though this has a maintenance cost, it makes the APImuch more convenient from Scala. A number of tests were added to verify the
behaviour of this wrapper.
The Scala module for Jackson doesn't provide any help for our current usage, so we don't
depend on it.
An attempt has been made to maintain the existing behaviour regarding when exceptions
are thrown. There are a number of cases where
JsonMappingExceptionwill be throwninstead of
ClassCastException, however. It is expected that users would not try to catchClassCastException.