Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make token stream settings as final and only set on construction #13112

Open
easyice opened this issue Feb 16, 2024 · 0 comments
Open

Make token stream settings as final and only set on construction #13112

easyice opened this issue Feb 16, 2024 · 0 comments

Comments

@easyice
Copy link
Contributor

easyice commented Feb 16, 2024

Description

As discussed in #13104, the current API allows for changing the configuration of token streams after construction(such as ShingleFilter), but it should be set only during construction. Perhaps we can impose some constraints on the API to prevent more such cases in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant