ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testClientRequestTimeout #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
nkalmar
approved these changes
Oct 3, 2018
850bcdc to
98012ee
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
@hanm Are u happy with simplifying this test? |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
asfgit
pushed a commit
that referenced
this pull request
Oct 12, 2018
Can't see a reason why testing again the create method without packet drop. Timeout scenario has already been tested and this part seem to make the test flaky. Removed. Author: Andor Molnar <andor@apache.org> Reviewers: nkalmar@cloudera.com, andor@apache.org Closes #653 from anmolnar/ZOOKEEPER-3159 (cherry picked from commit 6285f33) Signed-off-by: Andor Molnar <andor@apache.org>
|
This is committed too to 3.5 and master to reduce flaky test pressure. |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Can't see a reason why testing again the create method without packet drop. Timeout scenario has already been tested and this part seem to make the test flaky. Removed. Author: Andor Molnar <andor@apache.org> Reviewers: nkalmar@cloudera.com, andor@apache.org Closes apache#653 from anmolnar/ZOOKEEPER-3159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't see a reason why testing again the create method without packet drop. Timeout scenario has already been tested and this part seem to make the test flaky. Removed.