fix: removing InternalCustomResponseExceptionHandling in ASP.NET core… #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server that resulted in implementation details being leaked.
|
PR #899 looks similar and adds opt-in behavior. Should this PR be closed? |
|
I ended merging the similar #899 PR because it allowed users that want the existing behavior to be able to opt in to that behavior. PR 899 was released as part of version 8.0.0 of Amazon.Lamnda.AspNetCoreServer. It was a major version bump due to the slight breaking change behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: removing InternalCustomResponseExceptionHandling in ASP.NET core server that resulted in implementation details being leaked.
Issue #, if available: 886
Description of changes:
The default behavior of ASP.NET core when an unhandled exception is thrown in a controller is to respond with the type of exception in an HTTP header. This is done by the
InternalCustomResponseExceptionHandlingmethod. This leaks implementation details. Per this comment I have removed that behavior.Prior to this, overriding this behavior required override the
ProcessRequestmethod that called theInternalCustomResponseExceptionHandlingmethod since the latter is private protected. This PR does not change this behavior. One still has to overrideProcessRequestin order to change behavior on unhandled exceptions.[x] I have run the tests and they pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.