Fixed issue with ASP.NET Core Minimal API MapPost with complex types #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnj
reviewed
Mar 14, 2022
Libraries/test/Amazon.Lambda.AspNetCoreServer.Test/TestMinimalAPI.cs
Outdated
Show resolved
Hide resolved
…coming from the body by implement .NET 6 IHttpRequestBodyDetectionFeature interface
3624b2f to
9778c83
Compare
boblodgett
approved these changes
Mar 14, 2022
ganeshnj
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-toolkit-visual-studio#223
Description of changes:
This PR fixes an issue when using ASP.NET Core Minimal API and doing a post with a complex types. .NET 6 added a new feature collection called
IHttpRequestBodyDetectionFeatureto detect whether a response has a body. This was added to allow ASP.NET Core be able to tell the difference between not having a body versus explicitly passing an empty body.The fix was all in the
InvokeFeaturesclass. The rest of the PR is adding a test framework for writing unit tests for Lambda ASP.NET Core Minimal API projects.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.