Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .NET 8 and Native AOT for ASP.NET Core bridge libraries. #1668

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Add support for .NET 8 and Native AOT for ASP.NET Core bridge libraries. #1668

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4f7a95
Add support for .NET 8 and Native AOT for ASP.NET Core bridge libraries.
normj Feb 11, 2024
512d10c
Address PR feedback
normj Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Address PR feedback
  • Loading branch information
@normj
normj committed Feb 15, 2024
commit 512d10c936aad34abd8283c8d1ba58ce8279be61
4 changes: 2 additions & 2 deletions Libraries/src/Amazon.Lambda.AspNetCoreServer/Internal/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace Amazon.Lambda.AspNetCoreServer.Internal
public static class Utilities
{
/// <summary>
/// Method to make sure the Lambda implementation is the only registered implementaiton of IServer for ASP.NET Core runtime.
/// Method to make sure the Lambda implementation is the only registered implementation of IServer for ASP.NET Core runtime.
/// </summary>
/// <param name="services"></param>
public static void EnsureLambdaServerRegistered(IServiceCollection services)
Expand All @@ -33,7 +33,7 @@ public static void EnsureLambdaServerRegistered(IServiceCollection services)
}

/// <summary>
/// Method to make sure the Lambda implementation is the only registered implementaiton of IServer for ASP.NET Core runtime.
/// Method to make sure the Lambda implementation is the only registered implementation of IServer for ASP.NET Core runtime.
/// </summary>
/// <param name="services"></param>
/// <param name="serverType"></param>
Expand Down
4 changes: 3 additions & 1 deletion ...ies/src/Amazon.Lambda.Serialization.SystemTextJson/SourceGeneratorLambdaJsonSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ public SourceGeneratorLambdaJsonSerializer(Action<JsonSerializerOptions> customi
/// <param name="jsonSerializerContext"></param>
/// <param name="customizer"></param>
/// <param name="jsonWriterCustomizer"></param>
[Obsolete("The method is marked obsolete because the jsonSerializerContext parameter is unlikely to be created with the required JsonSerializerOptions for Lambda serialization. This will trigger confusing NullReferenceException.")]
[Obsolete("The method is marked obsolete because the jsonSerializerContext parameter is unlikely to be created with the required JsonSerializerOptions for Lambda serialization. " +
"This will trigger confusing NullReferenceException. The constructors that don't take an instance of jsonSerializerContext can be used for Native AOT because the reflection " +
"calls have been annotated to make them Native AOT compatible.")]
public SourceGeneratorLambdaJsonSerializer(TSGContext jsonSerializerContext, Action<JsonSerializerOptions> customizer = null, Action<JsonWriterOptions> jsonWriterCustomizer = null)
: base(jsonWriterCustomizer)
{
Expand Down
Loading