Add support for ITlsConnectionFeature and marshall the APIGW client cert to HttpContext (#786) #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normj
requested changes
Jan 6, 2021
Libraries/src/Amazon.Lambda.AspNetCoreServer/APIGatewayHttpApiV2ProxyFunction.cs
Show resolved
Hide resolved
| if (clientCertPem != null) | ||
| { | ||
| // Remove "--------BEGIN CERTIFICATE-----\n" and "-----END CERTIFICATE-----" | ||
| clientCertPem = clientCertPem.Substring(28, clientCertPem.Length - 53); |
There was a problem hiding this comment.
Same comment as above about verify the cert. Probably put it a utility method that converts incoming cert into the X509Certificate2.
There was a problem hiding this comment.
See comment above #787 (comment)
9b94083 to
bd4a713
Compare
damianh
commented
Jan 8, 2021
|
@normj Changes done as requested. Cheers. |
…tion and add a check the PEM starts and end with expected values.
normj
approved these changes
Jan 8, 2021
|
Thanks for the fast feedback and accepting @normj ! |
|
Thanks again. The PR was just released today in version 5.3.0 of Amazon.Lambda.AspNetCoreServer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #786
Description of changes:
ItlsConnectionFeaturesupport toInvokeFeaturesX509Certificate2and sets the feature property that then flows through to HttpContextAPIGatewayHttpApiV2ProxyRequestandAPIGatewayProxyRequestBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.