Migration tool mapping diffs #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
reviewed
Sep 13, 2024
| PACKAGE_MAPPING.put("certificatemanager", "acm"); | ||
| PACKAGE_MAPPING.put("cloudcontrolapi", "cloudcontrol"); | ||
| PACKAGE_MAPPING.put("cloudsearchv2", "cloudsearch"); | ||
| PACKAGE_MAPPING.put("cloudwatchevidently", "evidently"); | ||
| PACKAGE_MAPPING.put("logs", "cloudwatchlogs"); | ||
| PACKAGE_MAPPING.put("metrics","cloudwatch"); |
There was a problem hiding this comment.
Is metrics the package name for client side metrics? If so, the correct package is not cloudwatch. We don't support metrics yet in migration tool
There was a problem hiding this comment.
Yeah it is in the cloudwatchmetrics module
https://github.com/aws/aws-sdk-java/tree/master/aws-java-sdk-cloudwatchmetrics/src/main/java/com/amazonaws/metrics
Gotcha, will remove this mapping
zoewangg
approved these changes
Sep 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Package diffs based on https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/migration-steps.html
Edge case client diff for KinesisFirehose (v1) -> Firehose (v2)
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License