Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prettify JS code missed in #1185 #1386

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 15, 2020

Issue #, if available:
Refs: #1185

Description of changes:
prettify JS code missed in #1185

The command run in ./node_modules/.bin/prettier --write **/*.{ts,js,md,json} for prettifying code did not prettify JavaScript files. This appears to be an issue with bash process

$ pwd
/home/trivikr/workspace/aws-sdk-js-v3

$ ps -p $$
  PID TTY          TIME CMD
 1179 pts/0    00:00:00 bash

$ ./node_modules/.bin/prettier --write **/*.js
[error] No matching files. Patterns: node_modules/asn1.js node_modules/big.js node_modules/bn.js node_modules/decimal.js node_modules/des.js node_modules/hash.js node_modules/highlight.js node_modules/ipaddr.js node_modules/md5.js node_modules/sha.js

When zsh was used, it was able to prettify JS files:

zsh> pwd
/home/trivikr/workspace/aws-sdk-js-v3

zsh> ps -p $$
  PID TTY          TIME CMD
31103 pts/0    00:00:00 zsh

zsh> ./node_modules/.bin/prettier --write **/*.js
clients/client-cognito-identity/karma.conf.js 38ms
clients/client-s3/karma.conf.js 12ms
....

bash process was used in PR #1185 as zsh was giving argument list too long error

$ ./node_modules/.bin/prettier --write **/*.{ts,js,md,json}
zsh: argument list too long: ./node_modules/.bin/prettier

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1386 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1386   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files         287      287           
  Lines       11150    11150           
  Branches     2358     2358           
=======================================
  Hits         8817     8817           
  Misses       2333     2333           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5323a81...f7e9382. Read the comment docs.

@trivikr
Copy link
Member Author

trivikr commented Jul 15, 2020

Since JavaScript files from legacy integration tests were formatted, verified that legacy-integration tests succeed:

$ AWS_PROFILE=team yarn test:integration-legacy
yarn run v1.22.4
$ cucumber-js --fail-fast
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

153 scenarios (153 passed)
534 steps (534 passed)
1m01.733s
Done in 64.81s.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@trivikr trivikr merged commit 825538a into aws:master Jul 16, 2020
@trivikr trivikr deleted the prettify-js-code branch July 16, 2020 17:15
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants