docs: need to document consuming errors. #11
Comments
mingrammer
pushed a commit
that referenced
this issue
Mar 25, 2022
|
Fixed issue |
proost
added a commit
to proost/kinesumer
that referenced
this issue
Mar 25, 2022
* docs: add caution message for error channel * style: change grammar issue * fix: error can be ignored if channel is blocked * style: change comments sendErrorOrIgnore * style: change sendErrorOrIgnore to sendOrDiscardError, remove docs
mingrammer
pushed a commit
that referenced
this issue
Jul 14, 2022
* feat(api): add commit feature to kinesumer * docs: add comment for error message * feat: update multiple checkpoints * feat: add kinesumer to mark record & manual commit * feat: divide commit & consuming, add offset config * refactor: change code style to origin * style: change offsetmanagement to commit properties * fix: hanging if error channel is full (#11) (#13) * docs: add caution message for error channel * style: change grammar issue * fix: error can be ignored if channel is blocked * style: change comments sendErrorOrIgnore * style: change sendErrorOrIgnore to sendOrDiscardError, remove docs * refactor: remove updating checkpoints with 25 items * test: add unit tests for markrecord&commit * style: make comments more clear * test: add state store test * refactor: rename commitCheckPointPerStream to commitCheckPointsPerStream * refactor: follow ok idiom * refactor: remove send error when empty commit checkpoints * doc: remove meaningless comments * refactor: remove duplicated consumed nil records check * refactor: rename commit properties to commit config * test: remove inappropriate test for commitCheckPointsPerStream * refactor: remove cleanup function and move to after end of consuming * refactor: make clean up offset using cleanUpOffset function * test: rename works properly to works fine * refactor: rename default commit properties to commit config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
if not handle errors using
Errors(), maybe stop consuming forever.if first time error happens when consuming, then send errors to kinesumer errors. If not read from errors channel, channel blocked after second time error happen
Need Documentation for
Errors()The text was updated successfully, but these errors were encountered: