Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document ServerGarbageCollection for enabling Server GC #4245

Closed
mjrousos opened this issue Jan 29, 2018 · 6 comments
Closed

Document ServerGarbageCollection for enabling Server GC #4245

mjrousos opened this issue Jan 29, 2018 · 6 comments

Comments

@mjrousos
Copy link
Member

Current documentation does not cover how to enable server GC in .NET Core apps.

It would be useful to explain the ServerGarbageCollection project file property, as well as comparing it to the app.config gcServer property since some developers may not realize that different properties are used for projects targeting net46x/net47 compared to netcoreapp.

@mairaw
Copy link
Contributor

mairaw commented Jan 29, 2018

@mjrousos we do cover that property but in the mapping topic: https://docs.microsoft.com/en-us/dotnet/core/tools/project-json-to-csproj#runtimeoptions

We also have a proposed topic in issue #2642 which would cover all the SDK properties in .NET Core project. Would that cover what you're asking?

@mjrousos
Copy link
Member Author

I think the mapping doc isn't sufficient since someone writing a new ASP.NET Core app (for example) might not look at migration docs.

I think #2642 may cover it as long as we're sure to include ServerGarbageCollection among the MSBuild properties documented.

@mairaw
Copy link
Contributor

mairaw commented Jan 29, 2018

Yes, I know the mapping isn't sufficient @mjrousos but that's the only place where we explain that right now. There are a lot of requests coming for that topic so I'll try to make sure I review all issues that I'm closing as dupe when I'm working on that topic.

@ghogen who owns MSBuild docs now? I'm wondering if a lot of these requests we're getting is because the MSBuild reference doesn't cover the new .NET Core SDK properties as well.

@mairaw
Copy link
Contributor

mairaw commented Jan 29, 2018

Duplicate of #2642

@mairaw mairaw marked this as a duplicate of #2642 Jan 29, 2018
@mairaw mairaw closed this as completed Jan 29, 2018
@dotnetchris
Copy link

@gewarren
Copy link
Contributor

For anyone finding this issue, the GC options have been documented here: https://docs.microsoft.com/en-us/dotnet/core/run-time-config/garbage-collector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants