Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Gemini tracing #13801

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Conversation

TomeHirata
Copy link
Collaborator

@TomeHirata TomeHirata commented Nov 15, 2024

Related Issues/PRs

N/A

What changes are proposed in this pull request?

In this PR, I Introduced the auto tracing integration with Google Gemini SDK.
Users can use the autotracing of Gemini SDK easily with a code like this:

import os

import mlflow

# Turn on auto tracing for Gemini by calling mlflow.gemini.autolog()
mlflow.gemini.autolog()

# Import the SDK and configure your API key.
import google.generativeai as genai

genai.configure(api_key=os.environ["GEMINI_API_KEY"])

# Use the generate_content method to generate responses to your prompts.
model = genai.GenerativeModel("gemini-1.5-flash")
response = model.generate_content("The opposite of hot is")
print(response.text)

Proposed Solution

I implement the auto tracing by patching the following APIs of the Gemini SDK

  • genai.GenerativeModel.generate_content
  • genai.GenerativeModel.count_tokens
  • genai.ChatSession.send_message
  • genai.embed_content

Known TODOs

  • Support streaming usecase
  • Support asynchronous APIs

How is this PR tested?

  • Existing unit/integration tests
  • New unit/integration tests
  • Manual tests

GenerativeModel:
Screenshot 2024-11-15 at 15 10 08

countTokens:
image

ChatSession:
Screenshot 2024-11-15 at 15 47 44

embed_content:
image

Documents:
Screenshot 2024-11-15 at 16 29 40
Screenshot 2024-11-15 at 17 19 06

Does this PR require documentation update?

  • No. You can skip the rest of this section.
  • Yes. I've updated:
    • Examples
    • API references
    • Instructions

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Should this PR be included in the next patch release?

Yes should be selected for bug fixes, documentation updates, and other small changes. No should be selected for new features and larger changes. If you're unsure about the release classification of this PR, leave this unchecked to let the maintainers decide.

What is a minor/patch release?
  • Minor release: a release that increments the second part of the version number (e.g., 1.2.0 -> 1.3.0).
    Bug fixes, doc updates and new features usually go into minor releases.
  • Patch release: a release that increments the third part of the version number (e.g., 1.2.0 -> 1.2.1).
    Bug fixes and doc updates usually go into patch releases.
  • Yes (this PR will be cherry-picked and included in the next patch release)
  • No (this PR will be included in the next minor release)

Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
@github-actions github-actions bot added area/docs Documentation issues area/examples Example code rn/feature Mention under Features in Changelogs. labels Nov 15, 2024
Copy link

github-actions bot commented Nov 15, 2024

Documentation preview for 2babde1 will be available when this CircleCI job
completes successfully.

More info

Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick addition, @TomeHirata! Overall look good, just added minor comments.

Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Copy link
Collaborator

@B-Step62 B-Step62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once #13801 (comment) and #13801 (comment) are addressed! Great work @TomeHirata

Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
@TomeHirata TomeHirata added this pull request to the merge queue Nov 18, 2024
Merged via the queue into mlflow:master with commit 1bc1a5f Nov 18, 2024
49 checks passed
@TomeHirata TomeHirata deleted the feat-gemini-tracing branch November 18, 2024 06:05
B-Step62 pushed a commit to B-Step62/mlflow that referenced this pull request Nov 18, 2024
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
B-Step62 pushed a commit that referenced this pull request Nov 18, 2024
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
karthikkurella pushed a commit to karthikkurella/mlflow that referenced this pull request Jan 30, 2025
Signed-off-by: TomuHirata <tomu.hirata@gmail.com>
Signed-off-by: k99kurella <karthikkurella4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation issues area/examples Example code rn/feature Mention under Features in Changelogs. v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants