warn when mapy.cz is used in a source tag #9709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbycz
reviewed
Jun 23, 2023
I went through the changesets and most of them use directly `mapserver.mapy.cz` (some older used `mX.mapserver.mapy.cz` so I hope this regex should work and would not cause any false positives. Fixes openstreetmap#9708
|
Adding this validation is fine, but note that it likely does not do what you might have intended with this PR: it only shows a warning when
|
tyrasd
requested changes
Jul 12, 2023
There was a problem hiding this comment.
One small detail is missing here: There must be a translatable string with a description of why this source is not suitable for mapping in OSM, see https://github.com/openstreetmap/iD/blob/v2.25.2/data/core.yaml#L1810-L1813 how it was done for the other existing source tag validations.
|
Given the original issue is solved, can this PR be closed? |
|
Yes, thanks. This can be closed. Solved via openstreetmap/openstreetmap-website#4093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the changesets and most of them use directly
mapserver.mapy.cz(some older usedmX.mapserver.mapy.czso I hope this regex should work and would not cause any false positives.See #9708