Use compact and compressed model json by default #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #375 +/- ##
==========================================
+ Coverage 86.77% 86.79% +0.01%
==========================================
Files 336 336
Lines 10921 10922 +1
Branches 342 577 +235
==========================================
+ Hits 9477 9480 +3
+ Misses 1444 1442 -2
Continue to review full report at Codecov.
|
tovbinm
reviewed
Jul 30, 2019
It's handled by Hadoop TextInputFormat based on the filename extension transparently. On the write path the filename extension is appended based on compression codec. On the read path, you can even mix files with different compression codecs/extensions and uncompressed files in the same dir. |
adec34d to
527b3a1
Compare
tovbinm
approved these changes
Jul 30, 2019
Merged
gerashegalov
added a commit
that referenced
this pull request
Sep 11, 2019
Bug fixes: - Ensure correct metrics despite model failures on some CV folds [#404](#404) - Fix flaky `ModelInsight` tests [#395](#395) - Avoid creating `SparseVector`s for LOCO [#377](#377) New features / updates: - Model combiner [#385](#399) - Added new sample for HousingPrices [#365](#365) - Test to verify that custom metrics appear in model insight metrics [#387](#387) - Add `FeatureDistribution` to `SerializationFormat`s [#383](#383) - Add metadata to `OpStandadrdScaler` to allow for descaling [#378](#378) - Improve json serde error in `evalMetFromJson` [#380](#380) - Track mean & standard deviation as metrics for numeric features and for text length of text features [#354](#354) - Making model selectors robust to failing models [#372](#372) - Use compact and compressed model json by default [#375](#375) - Descale feature contribution for Linear Regression & Logistic Regression [#345](#345) Dependency updates: - Update tika version [#382](#382)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes #374
Describe the proposed solution
use compact serialization, apply gzip to it.
Describe alternatives you've considered
make this behavior configurable
Additional context
In a test scenario output is reduced from 1.6M to 188K