Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate instrumenting Grpc for service discovery #321

Open
okjesse opened this issue Feb 7, 2018 · 8 comments
Open

Investigate instrumenting Grpc for service discovery #321

okjesse opened this issue Feb 7, 2018 · 8 comments

Comments

@okjesse
Copy link

okjesse commented Feb 7, 2018

Is spring cloud plan to support grpc for a better performance? thanks

@spencergibb
Copy link
Member

To support it in what way?

@okjesse
Copy link
Author

okjesse commented Feb 7, 2018

Now spring cloud use rest for service call service,but the performance is not good enouth,
So i try to use http2 to fix this,but http2 need use https,i found http2+https is not
better than http1+keepalive,so do you have some suggest for service call in spring cloud to
have a better performance like in dubbo? thanks a lot!

@spencergibb
Copy link
Member

So spring cloud instruments rest template with service discovery. We also instrument webclient that does http 2. I think instrumentation for grpc is a good idea.

@spencergibb spencergibb changed the title About Grpc Support Investigate instrumenting Grpc for service discovery Feb 7, 2018
@okjesse
Copy link
Author

okjesse commented Feb 7, 2018

I also have suggest following:

  1. spring boot can support to be a grpc server,like https://github.com/LogNet/grpc-spring-boot-starter
  2. gateway can convert http request from web browser to a grpc request,and convert a grpc response to http response to web browser. https://github.com/grpc-ecosystem/grpc-gateway
  3. spring cloud security can integration grpc to protect resource server.
  4. client call(feign) could support gprc and support load blance like http.

Thanks a lot.

@okjesse
Copy link
Author

okjesse commented Feb 8, 2018

thank you!

@liu-yinwei
Copy link

any plan for grpc since this ticket isn't updated for a while...

@spencergibb
Copy link
Member

Not currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants