Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Abandoned
-
None
-
None
-
None
Description
Prologue: https://github.com/apache/kafka/pull/10656#issuecomment-836071563
Scenario:
- bump CheckStyle to a more recent version (8.36.2 -->> 8.41.1)
- introduce (temporarily !) maxErrors CheckStyle property (in order to count errors)
- execute gradle command: ./gradlew checkstyleMain checkstyleTest
- around 50 of 'Indentation' CheckStyle errors (across 18 source code files) are shown
Note: there were some changes related to indentation between CheckStyle 8.36.2 and 8.41.1: https://checkstyle.sourceforge.io/releasenotes.html#Release_8.41.1
What can be done (options):
- relax CheckStyle 'Indentation' rules (if possible)
- comply with new CheckStyle 'Indentation' rules (and change/fix indentation fir these source code files)
- there are some slim chances that this is a some kind of CheckStyle regression (maybe similar to this one: https://github.com/checkstyle/checkstyle/issues/9341). This should be checked with CheckStyle team.
Attachments
Issue Links
- depends upon
-
KAFKA-12572 Add import ordering checkstyle rule and configure an automatic formatter
- Resolved
- duplicates
-
KAFKA-18050 Upgrade the checkstyle version to 10.20.2
- Resolved
- is related to
-
KAFKA-12770 Gradle build: allow the CheckStyle version to be specified via parameter
- Closed